search

OpenSC / pkcs11-helper

Library that simplifies the interaction with PKCS#11 providers for end-user applications using a simple API and optional OpenSSL engine
Other
65 stars 43 forks source link

Build-fixes on LEDE #13

Closed nwf closed 7 years ago

nwf commented 7 years ago

Some time in the OpenSSL 1.1 timeline, RSA_METHOD and DSA_METHOD became opaque, while there are some scattered calls to sizeof(RSA_METHOD) and attempts to read, e.g. ->name from these. This appears to have been backported at least to 1.0.2l and possibly earlier. I "fixed" this by changing the version test within pkcs11h-openssl.c from 10100001 to 100020CF; I have no idea if this is the right fix.

If deprecated APIs are disabled, openssl/x509.h no longer recursively includes rsa.h, dsa.h, or dh.h. This is easily fixed by adding the appropriate includes, guarded by the appropriate ifndefs.

nwf commented 7 years ago

Argh. Sorry. Those fix compilation but not subsequent linking. If I fix it I'll reopen with corrected patches.

alonbl commented 7 years ago

Thanks! Can you please look at #14 and tell me if it is ok?