search

OpenSC / pkcs11-helper

Library that simplifies the interaction with PKCS#11 providers for end-user applications using a simple API and optional OpenSSL engine
Other
65 stars 43 forks source link

Messy tagging #29

Closed kloczek closed 3 years ago

kloczek commented 3 years ago

Just released new version has pkcs11-helper-1.27 however in reeality it is version 1.27.0. Other thing is that using repo name in tags is causing that for example autogenerated by github tar ball https://github.com/OpenSC/pkcs11-helper/archive/pkcs11-helper-1.27.tar.gz has inside pkcs11-helper-pkcs11-helper-1.27/ base directory.

It would be really nice on making next version switch to just <version> with dots or v<version> (because github/gitlab automatically skips leading v in tag strings) like in case of the great majority of the projects maintained in git repos.

alonbl commented 3 years ago

Please use the formal fit tarball and not GitHub auto generated artifacts.

On Tue, 17 Nov 2020 at 22:02 Tomasz Kłoczko notifications@github.com wrote:

Just released new version has pkcs11-helper-1.27 however in reeality it is version 1.27.0. Other thing is that using repo name in tags is causing that for example autogenerated by github tar ball https://github.com/OpenSC/pkcs11-helper/archive/pkcs11-helper-1.27.tar.gz has inside pkcs11-helper-pkcs11-helper-1.27/ base directory.

It would be really nice on making next version switch to just with dots or v (because github/gitlab automatically skips leading v in tag strings) like in case of the great majority of the projects maintained in git repos.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSC/pkcs11-helper/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJURLLG2VVZM4WZ7NSQCNDSQLJEXANCNFSM4TZA72VA .

kloczek commented 3 years ago

Tagged tar ball is only resource which guarantees that git committed after release will be applied on top of the exact version source tree.

I must regenerate libtool files because you are using buggy libtool before ./configure execution. In that case they is any difference between dist or tagged tar ball on building release package however using in tags just version allow easy swing between dist and tagged using exactly the same build procedure. If you don't care how easy is possible to use released by you resources to produce binary packages that is really bad .. Please understand that results of your work are used on another layer of the typical OSS stacks and you should be providing as easy interface to the next layers as possible. This is not accident that in case most of the git based projects as tags is used just version string.

alonbl commented 3 years ago

I appreciate your view, won’t change the scheme.

On Tue, 17 Nov 2020 at 22:33 Tomasz Kłoczko notifications@github.com wrote:

Tagged tar ball is only resource which guarantees that git committed after release will be applied on top of the exact version source tree.

I must regenerate libtool files because you are using buggy libtool before ./configure execution. In that case they is any difference between dist or tagged tar ball on building release package however using in tags just version allow easy swing between dist and tagged using exactly the same build procedure. If you don't care how easy is possible to use released by you resources to produce binary packages that is really bad .. Please understand that results of your work are used on another layer of the typical OSS stacks and you should be providing as easy interface to the next layers as possible. This is not accident that in case most of the git based projects as tags is used just version string.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/OpenSC/pkcs11-helper/issues/29#issuecomment-729184804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJURLPXLKNSMCZPHEI6GHTSQLMXXANCNFSM4TZA72VA .

kloczek commented 3 years ago

Any particular reasons? What about adding additional tags? I've presented not my view but set of some rational arguments which have nothing to do with my me or my view.

alonbl commented 3 years ago

I just don’t accept your arguments nor GitHub as an authority of how to export snapshots from git adding a prefix. Feel free to fork.

On Wed, 18 Nov 2020 at 6:44 Tomasz Kłoczko notifications@github.com wrote:

Any particular reasons? What about adding additional tags? I've presented not my view but set of some rational arguments which have nothing to do with my me or my view.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/OpenSC/pkcs11-helper/issues/29#issuecomment-729402883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJURLLPQAIKOKETCBPI4I3SQNGL7ANCNFSM4TZA72VA .

kloczek commented 3 years ago

What about start using actual version i tag? Last tag is suggests that is tis1.27 but actual version is 1.27..0.

kloczek commented 3 years ago

I just don’t accept your arguments nor GitHub as an authority of how to export snapshots from git adding a prefix. Feel free to fork.

I've not opened that ticket because something is wrong with github. Again: actual latest version is 1.27.0 and last tag is 1.27. I'm closing that issue ticket but again please

Please do something about kipp the same version in actual git tag and what is hardcoded in configure.ac. I have some automation which relies on git tags and taht automation fails on only pkcs11-helper :( I can understand that now it is to late to fix that tag but please at least do not repeat the same not matching tag with actual version one next rlease. Please ..