search

OpenSCAP / oval-graph

Understand OVAL results in a blink of an eye
Apache License 2.0
34 stars 19 forks source link

test_commands.sh: always show test and its result #188

Closed matusmarhefka closed 3 years ago

matusmarhefka commented 3 years ago

This will show test name and its result all the time not only when using verbose mode (which shows also command outputs).

matejak commented 3 years ago

Is the aim to show results of all tests, or just of failed ones? The Unix philosophy advocates that programs should not report by default when subtasks go well according to expectations. In this context, I see that the failure should be reported always, but do we need the passing test report outside of the verbose mode?

matusmarhefka commented 3 years ago

Is the aim to show results of all tests, or just of failed ones? The Unix philosophy advocates that programs should not report by default when subtasks go well according to expectations. In this context, I see that the failure should be reported always, but do we need the passing test report outside of the verbose mode?

Right now the test script prints only a version of oval-graph in non-verbose mode so it is not really clear what is being tested. The idea was to see what tests are being executed and their results (even passing ones) without additional verbosity produced by the verbose mode. But I don't have a strong opinion about it.

Honny1 commented 3 years ago

Hello @matusmarhefka and @matejak, I suggest closing this PR and creating an issue to change the output of test_commands.sh. I think it will be good to show the results only when something is wrong and to hide the oval-graph version. Then the test_commands.sh script would create a log file with the complete result.

Honny1 commented 3 years ago

190