search

OpenSWE1R / swe1r-tools

A collection of tools to work with files of the 1999 Game "Star Wars Episode 1: Racer"
GNU General Public License v2.0
21 stars 6 forks source link

Fix for Issue #8 #13

Open rienafairefr opened 6 years ago

rienafairefr commented 6 years ago

Stumbled upon this repo, This should solve the issue #8 with the hardcoded paths, using argparse to parse incoming CLI arguments. Didn't really test, don't have data files handy, but this should work

JayFoxRox commented 6 years ago

Thanks a lot for looking into it, I'll test and continue review later.

(Also check-out the main project, which is a loader and re-implementation of the game)

rienafairefr commented 6 years ago

Yes, I stumbled upon that main project, I'll try it out as well ^^ I've added some commits, it works fine now with the added step to create the dir if it doesnt exist :-)

JayFoxRox commented 6 years ago

Sorry for the delay on this one; I'm still unhappy with the quality to be honest. I don't like how this moves a basic operation such as argument parsing into a new file and that it automatically creates the folder, even when just doing "--help".

I started fixing this locally but got distracted with other things (hence the delay). I'll try to get back to this soon though.