MatcherFactory Lenient Syntax May Be a Longer-Term Problem

OpenSextant / OpenSextantToolbox

A geotagger and entity extractor

Other

15 stars 7 forks source link

MatcherFactory Lenient Syntax May Be a Longer-Term Problem #6

Closed CraigMiloRogers closed 11 years ago

CraigMiloRogers commented 11 years ago

MatcherFactory.config(...) checks a URL for http: and file: prefixes. If it doesn't find either, it assumes that the string provided is a local file without URL wrapping. Although this policy should be a convenience for the developer, it runs contrary to the spirit and purpose of URLs (URIs, etc.), and may lead to support problems in the long term.

dlutz2 commented 11 years ago

This was intentional. We wished to support both URL and file path syntax for this variable,with file syntax being the majority case for OpenSextant. Also since the solr instance referenced is not necessarily exclusively used by OpenSextant, we wanted to be able to use the existing value of solr.home (which is file path)