search

OpenShot / libopenshot-audio

OpenShot Audio Library (libopenshot-audio) is a free, open-source project that enables high-quality editing and playback of audio, and is based on the amazing JUCE library.
http://www.openshot.org
GNU General Public License v3.0
253 stars 100 forks source link

Rename build environment files so we can glob for them #126

Closed ferdnyc closed 3 years ago

ferdnyc commented 3 years ago

The Gitlab builders have been writing metadata into a file named <installpath>/share/<reponame> which is impossible to glob for. So, rename all those files to <installpath>/share/<reponame>.env.

ferdnyc commented 3 years ago

@jonoomph

The libopenshot-audio, libopenshot, and openshot-qt files from the build/install-x??/share/ directory get copied into the src/settings directory of the openshot-qt install, along with the corresponding .log files.

(These are the files that contain metadata like:

CI_PROJECT_NAME:libopenshot
CI_COMMIT_REF_NAME:mingw-paths
CI_COMMIT_SHA:f902996b730f6b07d93baae3afe1430fa58e9572
CI_JOB_ID:25012
CI_PIPELINE_ID:7344
VERSION:0.2.5-dev3
SO:19

...The ones I've now renamed to libopenshot.env (and similar) to make them globbable when setting the artifact paths for the runner.)

.. Do you happen to remember if they're used for anything, and if so, what? Inside OpenShot itself, I mean. I know they're used by the code in installer/*.py, and I've adjusted those scripts to expect the .env extension.

ferdnyc commented 3 years ago

.. Do you happen to remember if they're used for anything,

It doesn't appear that way. I see code that reads the .log files in about.py, but it appears the metadata files are never looked at from within OpenShot itself.