search

OpenSlides / openslides-meta

MIT License
0 stars 12 forks source link

Add anchors #69

Closed bastianjoel closed 5 months ago

bastianjoel commented 6 months ago

Closes #12

bastianjoel commented 6 months ago

Search service supports this now: https://github.com/OpenSlides/openslides-search-service/pull/78

jsangmeister commented 5 months ago

Do the changes from https://github.com/OpenSlides/openslides-search-service/pull/78 also have to be included in the AU before we merge this?

bastianjoel commented 5 months ago

@ostcar Do you want to adopt the changes?

ostcar commented 5 months ago

I am not sure. If go generate ./... works, and the tests pass, then it can be merged. If not, I have to make some changes.

Do you want to test this? I am not sure, If I find the time this weekend.

jsangmeister commented 5 months ago

As suspected, does not work:

2024/04/05 10:42:47 Can not parse model definition: unmarshalling models.yml: decoding models: field object without type: [1:1] sequence was used where mapping is expected
        >  1 | &languages
               ^
           2 |     - en
           3 |     - de
           4 |     - it
           5 |

@bastianjoel can you port the changes? Or can the code be reused somehow, maybe in the common package which AU and ICC also use?

bastianjoel commented 5 months ago

I will port the changes.