OpenSlides / openslides-voting

Voting plugin for OpenSlides 2.x
MIT License
5 stars 4 forks source link

Speaker list voting. #61

Closed jwinzer closed 6 years ago

jwinzer commented 6 years ago
FinnStutzenstein commented 6 years ago

@jwinzer Can you move the keypad update code out of the validation, thanks! The rest looks good, I'll merge, if the code has been moved.

jwinzer commented 6 years ago

@FinnStutzenstein Strictly speaking it's more than validation. However, I wanted to avoid looping yet another time thru the votes.

FinnStutzenstein commented 6 years ago

@jwinzer I added one commit. If it's ok, I'll rebase and merge.

jwinzer commented 6 years ago

@FinnStutzenstein Here is another issue. We're violating the DRY principle here and should move this to a separate method: SubmitVotes SubmitCandidates

FinnStutzenstein commented 6 years ago

@jwinzer If you want, you can clean this up. But we should first merge this one.

jwinzer commented 6 years ago

Ok, go ahead and merge. I won't have time to work on the plugin until later this week.

jwinzer commented 6 years ago

@FinnStutzenstein WAIT! You need to call update_keypads_from_votes at the end of SubmitKeypads. That's the whole purpose of that method!

FinnStutzenstein commented 6 years ago

@jwinzer Jep, I didn't saw the last validate_input_data.