search

OpenSmalltalk / opensmalltalk-vm

Cross-platform virtual machine for Squeak, Pharo, Cuis, and Newspeak.
http://opensmalltalk.org/
Other
553 stars 111 forks source link

getGoodSpurVM.sh does not work on Mac 32 bits #284

Open hernanwilkinson opened 5 years ago

hernanwilkinson commented 5 years ago

It tries to read "squeak.cog.spur_macos32x86" instead of "squeak.cog.spurmacos32x86"

hernanwilkinson commented 5 years ago

I do not have access to create a branch so neither a pull request, so I'm coping here the diff that solves the issue: diff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh index da8326af4..36022892e 100755 --- a/image/getGoodSpurVM.sh +++ b/image/getGoodSpurVM.sh @@ -15,8 +15,8 @@ else exit 1 fi case $OS in

gcotelli commented 5 years ago

Fork the repository into your personal account , and create your branch there. Then you can do a PR against the main repo.

On Sun, Sep 16, 2018, 10:34 Hernan Wilkinson notifications@github.com wrote:

I do not have access to create a branch so neither a pull request, so I'm coping here the diff that solves the issue: diff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh index da8326af4..36022892e 100755 --- a/image/getGoodSpurVM.sh +++ b/image/getGoodSpurVM.sh @@ -15,8 +15,8 @@ else exit 1 fi case $OS in

-

 Darwin)

-

         VOLUME="squeak.cog.spur_macos32_x86_$LATESTRELEASE"

-

 Darwin)

-

         VOLUME="squeak.cog.spur_macos32x86_$LATESTRELEASE"
         LATESTVM="$VOLUME.dmg"
         VM=Squeak.$LATESTRELEASE.app
         if [ ! -d $VM ]; then

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAleCMD9McLGpxum_KW9n64bErXhTx4ks5ublNWgaJpZM4Wq2LV .