OpenSmalltalk / opensmalltalk-vm

Cross-platform virtual machine for Squeak, Pharo, Cuis, and Newspeak.
http://opensmalltalk.org/
Other
557 stars 111 forks source link

The VM is no longer passing command line arguments to the image #668

Closed stormwatch closed 10 months ago

stormwatch commented 10 months ago

How to replicate:

Run <path to release candidate.app> <image> one two three four.

Then evaluate:

| i a |
i := 0.
a := Smalltalk getSystemAttribute: i.
[a notNil] whileTrue: [
    Transcript showln: { i. a}.
    i := i + 1.
    a := Smalltalk getSystemAttribute: i ].

Expected behaviour as in the latest stable relase (2022)

The transcript logs all command line arguments:

(0 '/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakStable.app/Contents/MacOS/Squeak')

(1 '/Users/eze/.local/src/Smalltalk/Squeak/Squeak6.0-22104-64bit.image')

(2 'one')

(3 'two')

(4 'three')

(5 'four')

Behaviour using the current release candidate VM

The transcript logs only the vm executable and the image

(0 '/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakRC.app/Contents/MacOS/Squeak')

(1 '/Users/eze/.local/src/Smalltalk/Squeak/Squeak6.0-22104-64bit.image')

Tested in both Cuis and Squeak.

Might be related to #655.

krono commented 10 months ago

Can you share the actual commandline please?

stormwatch commented 10 months ago

Can you share the actual commandline please?

Sure thing!

cd to the image dir, then tried:

/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakRC.app/Contents/MacOS/Squeak Squeak6.0-22104-64bit.image one two three four

against:

/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakStable.app/Contents/MacOS/Squeak Squeak6.0-22104-64bit.image one two three four

and similarly for Cuis tried:

/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakRC.app/Contents/MacOS/Squeak Cuis6.0-6090.image one two three four

against:

/Users/eze/.local/src/Smalltalk/OpenSmalltalk/SqueakStable.app/Contents/MacOS/Squeak Cuis6.0-6090.image one two three four

krono commented 10 months ago

Yeah nobody is poulating commandLineArguments, I have a look

krono commented 10 months ago

Yeah, that was my fault, see 5b064fcae9254b60ac69e8a3b97c6c51629b9d48

krono commented 10 months ago

@marceltaeumel 1b15c7e0654934898eec152d231f87ab704d7040 is relevante for the RC. I'm sorry