Interval Days '1' cannot be used with OSPi

OpenSprinkler / OpenSprinkler-App

A mobile interface for the OpenSprinkler irrigation device. Designed to allow manual control, program management (preview, add, edit, and delete), initiation of a run-once program, viewing graphical and tabulated representations of log data, viewing device status, adjusting rain delay, and changing of OpenSprinkler settings.

https://opensprinkler.com

GNU Affero General Public License v3.0

168 stars 91 forks source link

Interval Days '1' cannot be used with OSPi #131

Closed kpfleming closed 1 year ago

kpfleming commented 2 years ago

https://github.com/OpenSprinkler/OpenSprinkler-App/blob/b9e6d0a2c6a36e539e2a9c04ea8f762cc39afb17/www/js/main.js#L9136

I've got OSPi installed from the master branch, and this app installed from the master branch, but I can't set 'Interval Days' to 1, only 2 or higher. The code linked above appears to restrict this feature to only OS versions 2.199 or above, but that function always returns false for OSPi, so OSPi users can't get the benefit of this change.

rayshobby commented 1 year ago

The checkOSVersion here refers to firmware version. OSPi can run firmware 2.1.9(9) so this should not be a problem for OSPi as long as you update to the latest firmware.