search

OpenSprinkler / OpenSprinkler-App

A mobile interface for the OpenSprinkler irrigation device. Designed to allow manual control, program management (preview, add, edit, and delete), initiation of a run-once program, viewing graphical and tabulated representations of log data, viewing device status, adjusting rain delay, and changing of OpenSprinkler settings.
https://opensprinkler.com
GNU Affero General Public License v3.0
177 stars 94 forks source link

WIP: Allow config of MQTT server and port #86

Closed PeteBa closed 4 years ago

PeteBa commented 5 years ago

This PR contains an alternative App interface for the MQTT capability under development on Firmware inspired by the work of jbaudoux in PR #80 and conversation on the Firmware equivalent PR. This assumes that all MQTT messages will be published by Firmware to the Broker allowing any client to select which messages to subscribe. The interface allows for specifying the Broker server and port.

@jbaudoux, based on our conversation I've submitted this alternative approach. If you agree then we can close #80.

PeteBa commented 5 years ago

Thanks Samer. Just need to co-ordinate with Ray to put this live with the equivalent Firmaware PR 108

salbahra commented 4 years ago

Anyone know the status of this PR?

Thanks!

PeteBa commented 4 years ago

Samer, closing as I'm no longer active on this. The basic config elements are complete (mqtt server and port config). There is more advanced functionality that could be supported (e.g. mqtt username & password etc) if desired. The commits are there for anyone to pick up.

rayshobby commented 4 years ago

Just as a heads up: we are preparing to integrate the mqtt branch to master. I see that this PR and the mqrtt-config branch have been deleted. We will re-submit this branch as a new PR, with some minor improvements such as allowing MQTT user name and password. Sorry Pete and jbaudoux for the long delay, and thanks for the contributions.

PeteBa commented 4 years ago

Great stuff. Thanks for pushing this forward Ray.

rayshobby commented 4 years ago

Pete, would you mind re-opening your PR so we can merge it? Thanks.