OpenSprinkler / OpenSprinkler-Firmware

OpenSprinkler Unified Firmware for OpenSprinkler, OpenSprinkler Pi, and OpenSprinkler Beagle.
http://www.opensprinkler.com
GNU General Public License v3.0
475 stars 286 forks source link

Containerize2 #225

Closed developer79433 closed 8 months ago

developer79433 commented 1 year ago

Containerise this and silence many compiler warnings. Closes #50 .

developer79433 commented 1 year ago

Here's a fluffy but still reasonably informative discussion of the benefits of containerisation: https://circleci.com/blog/benefits-of-containerization/

The parts about "faster" and so on are comparing containers to virtual machines, so are probably irrelevant to OpenSprinkler. Bare metal is faster than containers (slightly). But the other benefits, in particular portability and easier management, are relevant.

developer79433 commented 1 year ago

Heya @rayshobby , could you please take a look?

developer79433 commented 1 year ago

@tonyrui , I see you've been active on OS recently, could you take a look at this please?

jbalonso commented 1 year ago

Heads-up: I snagged this branch for my fork and stapled on some github actions workflows (my first). Now I have prebuilt images serving out of ghcr.io.

varac commented 8 months ago

What's to state of this ? Why does this PR got closed, not merged ?

developer79433 commented 7 months ago

It got automatically closed when I deleted the 'containerise2' branch in my fork, as part of a cleanup. I'll create another PR and link it here.

developer79433 commented 7 months ago

Ok, see #262 .