search

OpenSprites / OpenSprites-Origin

The original OpenSprites website, written in PHP. Discontinued - remains for historical reasons. See OpenSprites-Next for the new generation of Scratch resource sharing.
MIT License
19 stars 9 forks source link

Remove ajax.googleapis.com dependance #191

Closed jamesd-uk closed 8 years ago

jamesd-uk commented 8 years ago

This is fetched from Google in the Header.html file. Is this required - can we not host the file ourselves?

towerofnix commented 8 years ago

BUT CHEESEEATER THAT WOULD MEAN ADDING 200 EXTRA KB OF DATA WE CAN'T POSSIBLY SPARE THAT

EDIT: Why are we using ajax libs when XMLHttpRequest works fine (especially with promises)? :package:

MegaApuTurkUltra commented 8 years ago

We're not using ajax libs. It's literally just jquery :package:

jamesd-uk commented 8 years ago

So... does that mean we still need to fetch that from Google?

towerofnix commented 8 years ago

Why are we using jQuery when document.querySelector works fine? :package:

bates64 commented 8 years ago

Because jQuery is swaggy.

bates64 commented 8 years ago

@The-Cheese-Eater commented on 16 Nov 2015, 07:06 GMT:

So... does that mean we still need to fetch that from Google?

No, just download the file and stick it in includes/js, it's just because whoever first made Header.html couldn't be bothered to download it.

And evidently nobody could be bothered afterwards either.

towerofnix commented 8 years ago

Because jQuery is swaggy

so are promises

jamesd-uk commented 8 years ago

@GrannyCookies Thanks, will do :P