search

OpenTechStrategies / streetcrm

StreetCRM is a free software contact management application
Other
5 stars 4 forks source link

WIP: Fix issues with search back button, use GET for advanced search #337

Closed pjsier closed 1 year ago

pjsier commented 7 years ago

Working on #330. This is still a work in progress, but I wanted to get feedback on whether we could use GET for the advanced search instead of POST. From some initial tests, every filter type still seems to work, and exports work as well.

cecilia-donnelly commented 7 years ago

Hey @pjsier -- is this ready for me to look at? Was there something in particular you wanted me to test?

pjsier commented 7 years ago

@cecilia-donnelly right now I just wanted to see if you thought there were any issues with using GET instead of POST for the advanced search. I only just got it working so it's not quite ready to look at yet

kfogel commented 5 years ago

I pondered and read up on security implications. My initial take is that there isn't really much difference, especially over https. https://stackoverflow.com/questions/198462/is-either-get-or-post-more-secure-than-the-other for more.

cecilia-donnelly commented 1 year ago

Hello! Do you think this can be closed? (I happened to be looking in the "mentioned" tab of my PR list on GitHub and saw it hanging around.)

Hope you are both well. :)

pjsier commented 1 year ago

That’s fine with me, hope you’re doing well too!