search

OpenTimelineIO / otio-aaf-adapter

OpenTimelineIO Advanced Authoring Format (AAF) Adapter
Apache License 2.0
16 stars 6 forks source link

AAFReader: Added kind support for auxiliary AAF tracks (#28) #27

Closed timlehr closed 8 months ago

timlehr commented 10 months ago

Fixes #28

Description

Makes sure non audio / video tracks get a kind string assigned. I added an AAF_ prefix, followed by the AAF track kind.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c480e0) 90.15% compared to head (951e3af) 90.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ======================================= Coverage 90.15% 90.15% ======================================= Files 3 3 Lines 1107 1107 ======================================= Hits 998 998 Misses 109 109 ``` | [Flag](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/27/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/27/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO) | `90.15% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO) | Coverage Δ | | |---|---|---| | [...\_aaf\_adapter/adapters/advanced\_authoring\_format.py](https://app.codecov.io/gh/OpenTimelineIO/otio-aaf-adapter/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenTimelineIO#diff-c3JjL290aW9fYWFmX2FkYXB0ZXIvYWRhcHRlcnMvYWR2YW5jZWRfYXV0aG9yaW5nX2Zvcm1hdC5weQ==) | `85.93% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timlehr commented 10 months ago

@reinecke @markreidvfx added a test for this change.

reinecke commented 10 months ago

LGTM - But I'll let @markreidvfx have the final 👍 since he's more deeply familiar with the adapter.

timlehr commented 9 months ago

@markreidvfx any opinion on this?

markreidvfx commented 9 months ago

sorry for the delay. LGTM.

Something to be aware of is that media_kind could have spaces in it. I've seen it be inconsistent between AAF files, namely with the Descriptive Metadata media_kind for markers. This is would be more of issue for the AAF writer.