OpenTire / OpenTirePython

An open-source mathematical tire modelling library
MIT License
46 stars 17 forks source link

No ability to choose what output we want #10

Closed bertaveira closed 3 years ago

bertaveira commented 3 years ago

If I am not mistaken the solvers implemented have no ability to pick what you need to solve. For example if you only want to obtain the longitudinal force you will also get the lateral one.

This results in a big number of unnecessary extra calculations. It might not be critical for just analysing a tire but if the objective is for this to grow and be usable everywhere then this will become a limitation very fast.

I had this problem last year when I built a 4 wheel GGV generator and I was using MFeval which has the same approach of solving everything. Because some outputs required minimum search it took a second do solve which might not seem critical at first but when you have a simulator that runs theses calculations over 10 million times it takes literally weeks to finish a simulation. I ended up programming myself by hand and optimising it and now takes 30 sec. This just to explain that not being able to choose what exactly you want to calculate is a big limitation down the road and that efficient code should be implemented from the start because changing after is a pain.

Other than that I like the project (I was just told by someone). I would like to contribute to the project and would be even more inclined to do so if I was allowed to make this change so it becomes useful to me too. What's your workflow for people to contribute? I am part of a formula student team from Portugal FST Lisboa and one of my roles last year was tire analysis, build software to do so and build simulators.

bertaveira commented 3 years ago

My mistake. Noticed it has the ability to do so. It is just not being used. I'll close this issue