D-Bus API: requests for improvements

grzegorz-gutowski commented 3 months ago

I would like to see the following changes to Python/D-Bus API:

Multiple calls to Connect (and possibly other state-changing functions) on a session should be silently ignored and not cause any troubles. Currently, calling Connect twice kills the session. This is especially important for scenarios where there are multiple applications trying to control a single session.
Adding some mechanism for applications to get notifications on added/removed configurations (similarly to notifications on added/removed sessions).
Adding GetConfiguration to session object that would return the path of configuration that was used to start the session. It is possible that this configuration no longer exists.
Similarly, adding GetSessions to configuration object that would return the paths of sessions started using this configuration. Currently, you can use LookupConfigName in session manager that looks up sessions by the name of configuration. This is not the same, as there could be multiple configurations with the same name!
Adding a way to get information when the session was started.
Similarly for configurations, the information when the configuration was imported, and when was the last time it was used to start a session.

I understand that work on these only makes sense after resolving #171 in v22.

grzegorz-gutowski commented 3 months ago

Sorry, I've learned that some of the information I need is already available via dbus, but not explicitly in Python. You can access them via Session.GetProperty().

dsommers commented 3 months ago

Feel free to send patches :wink:

dsommers commented 1 month ago

Multiple calls to Connect (and possibly other state-changing functions) on a session should be silently ignored and not cause any troubles. Currently, calling Connect twice kills the session. [...]

Adding some mechanism for applications to get notifications on added/removed configurations (similarly to notifications on added/removed sessions).

These two items should now incorporated in what will be the v22_dev release we're wrapping up. The development snapshots should already carry the functionality.

Fedora Copr: https://copr.fedorainfracloud.org/coprs/dsommers/openvpn3-devsnapshots/ Ubuntu PPA: https://launchpad.net/~djpig/+archive/ubuntu/openvpn/

OpenVPN / openvpn3-linux

D-Bus API: requests for improvements #244