OpenVisualCloud / CDN-Transcode-Sample

Media transcoding is a key function for live video broadcasting, streaming, and video on demand use cases in a CDN network. The CDN Transcode sample (not a finished product) provides a reference pipeline to build an out-of-box 1:N CDN streaming transcode service example.
Other
120 stars 37 forks source link

make failed due to no m4 , it should be included in the "script/install_dependency.sh" #159

Open meiyanz opened 4 years ago

meiyanz commented 4 years ago

Issue Description: compile failure "make " on the pure machine of the latest version. Error log: Scanning dependencies of target build_docker_swarm ../../../deployment/docker-swarm/build.sh: line 10: m4: command not found deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/build.make:57: recipe for target 'deployment/docker-swarm/CMakeFiles/build_docker_swarm' failed make[2]: [deployment/docker-swarm/CMakeFiles/build_docker_swarm] Error 127 CMakeFiles/Makefile2:198: recipe for target 'deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/all' failed make[1]: [deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/all] Error 2 Makefile:83: recipe for target 'all' failed make: * [all] Error 2 Reproduce Rate: 100%. Command : make The commit information: commit 2c591a86d60b5f9144fd8fcce9e436e2b0b035b7 Reproduce**: $ git clone https://github.com/OpenVisualCloud/CDN-Transcode-Sample.git $ cd CDN-Transcode-Sample $ sudo -E ./script/install_dependency.sh $ sudo mkdir -p /etc/systemd/system/docker.service.d $ printf "[Service]\nEnvironment="HTTPS_PROXY=$https_proxy" "NO_PROXY=$no_proxy"\n" | sudo tee /etc/systemd/system/docker.service.d/proxy.conf $ sudo systemctl daemon-reload $ sudo systemctl restart docker $ mkdir build && cd build $ cmake ../ -DNVODS=1 -DNLIVES=0 $ make

xwu2git commented 4 years ago

Is it a difficult system? m4 is needed for both docker swarm and Kubernetes build. yes, m4 is needed. The minimum dependencies are: cmake, m4, awk, sed, grep, cut, and then a fully functional docker, and one of docker (swarm), kubectl, or helm.

BTW, the script install_dependency.sh actually installs too many non-essential dependencies. I would not recommend to run it as a build step. @TangZhiZhen, could you clean it up?

xwu2git commented 4 years ago

For example, docker-ce should not be installed in install_depedency.sh. The docker choice should be left to the user, which may prefer to use docker-ee instead.