Fix FFmpeg audio plugin sample rate to be 44100

OpenVisualCloud / Media-Transport-Library

A real-time media transport(DPDK, AF_XDP, RDMA) stack for both raw and compressed video based on COTS hardware.

BSD 3-Clause "New" or "Revised" License

171 stars 55 forks source link

Fix FFmpeg audio plugin sample rate to be 44100 #952

Closed ko80 closed 3 months ago

ko80 commented 3 months ago

This PR includes the commits below

Fix FFmpeg audio plugin sample rate to be 44100
Refactor FFmpeg audio plugin sample rate parsing

skolelis commented 3 months ago

Here and now - it is ok. But side comment: I would create constants for those values, as they appear in the code more times (6x "44100", and other frequencies - also...)

PanKaker commented 3 months ago

Here and now - it is ok. But side comment: I would create constants for those values, as they appear in the code more times (6x "44100", and other frequencies - also...)

Sounds like a good idea. Could you please create a constant for that?

skolelis commented 3 months ago

ko80 commented 3 months ago

The 44.1k ST3x dilemma is weird, otherwise it's fine. I see it is the same all over the repo, but not sure why. Perhaps the ST30 standard does not define 44.1k as a valid sampling, but ST31 does?

I suppose this shouldn't extend the current PR scope. But yes, ST2110-30 defines 44100 Hz as a supported sampling frequency.