coderabbitai[bot]
commented
1 week ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes involve the removal of three deprecated functions (is_remote_list, translate_remote, and translate_list) from the ovos_config/models.py file, along with the removal of the reload method from the RemoteConf class. The docstring for the RemoteConf class was updated to clarify its role as a configuration dictionary managed by an external service. Additionally, the mycroft.conf configuration file underwent significant modifications, including the removal of several settings related to data collection, skill management, and server configurations, streamlining the overall configuration. The requirements/extras.txt file was deleted, and several dependencies were removed or updated in requirements/tests.txt. Lastly, the extras_require parameter was removed from setup.py.
Changes
| File | Change Summary |
|---|---|
| ovos_config/models.py | Removed methods: is_remote_list, translate_remote, translate_list, and reload. Updated docstring for RemoteConf. |
| ovos_config/mycroft.conf | Removed settings: "opt_in", "upload_skill_manifest", "sync2way", "autogen_meta". Removed key from protected keys: "opt_in". Entire section removed: "server". |
| requirements/extras.txt | Deleted file; removed dependency: ovos-backend-client>=0.1.0,<2.0.0. |
| requirements/tests.txt | Removed dependencies: sphinx==2.2.1, sphinx-rtd-theme==0.4.3, mock_msm~=0.9.2, ovos-stt-plugin-vosk>=0.1.3, python-vlc==1.1.2. Updated: ovos-bus-client version constraint changed from ~=0.0.8 to <2.0.0. |
| setup.py | Removed extras_require parameter from setup(). |
Possibly related PRs
- #183: This PR directly relates to the main PR as it involves the removal of the same deprecated functions (
is_remote_list,translate_remote,translate_list) and thereloadmethod from theRemoteConfclass inovos_config/models.py, indicating a significant overlap in changes made to the same code elements.
Suggested reviewers
- NeonDaniel
🐰 "In the code, a change took flight,
Functions deprecated, now out of sight.
With a hop and a skip, we simplify,
Remote confs managed, oh my, oh my!
A clearer path, a lighter load,
Onward we go, down the coding road!" 🐇
[!WARNING]
Rate limit exceeded
@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 52 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 1aef456e8993d7218e293426412aaae2b0c6c323 and 2f54af0c035e7176ea1873547685ae78bb23d21d.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Summary by CodeRabbit
New Features
RemoteConfclass to clarify its purpose.mycroft.confconfiguration by removing unnecessary settings related to data collection and skill management.Bug Fixes
reloadmethod.opt_insetting and related keys from the configuration.Chores
requirements/extras.txtfile and its dependencies.requirements/tests.txtfile by removing several dependencies and adjusting version constraints.extras_requireparameter fromsetup.py.