Closed JarbasAl closed 1 month ago
The changes in this pull request primarily involve modifying import statements for the MycroftSkill
class and related components across multiple files, transitioning from the ovos_workshop.skills.mycroft_skill
module to ovos_workshop.skills.ovos
. This adjustment maintains backward compatibility while updating the underlying implementation. Additionally, a deprecation warning is added to inform users about the future removal of the mycroft
module. Several requirements files are also updated to reflect changes in package dependencies and version constraints.
File Path | Change Summary |
---|---|
mycroft/__init__.py |
Added a deprecation warning for the mycroft module. |
mycroft/skills/__init__.py |
Updated __all__ to reflect changes in imports. |
mycroft/skills/common_iot_skill.py , mycroft/skills/core.py , mycroft/skills/mycroft_skill/__init__.py , mycroft/skills/mycroft_skill/mycroft_skill.py |
Changed import from ovos_workshop.skills.mycroft_skill to ovos_workshop.skills.ovos , renaming OVOSSkill to MycroftSkill . |
ovos_core/intent_services/fallback_service.py |
Updated import statement for FallbackMode from ovos_workshop.skills.fallback to ovos_workshop.permissions . |
requirements/* |
Various updates to dependencies, including additions, removals, and version constraint updates across multiple requirements files. |
mycroft/skills/intent_services/adapt_service.py
, which reflects a similar shift in the underlying implementation of skill classes as seen in the main PR's modification of the MycroftSkill
import.ovos_core/intent_services/__init__.py
and related files, which aligns with the main PR's focus on modifying imports and maintaining backward compatibility in the skill class structure.packaging
, refactor
🐇 In the meadow, skills take flight,
With imports changed, all feels right.
A warning here, a version there,
Mycroft hops on, with skills to share!
🌼 Let's embrace the new, with joy and cheer!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.93%. Comparing base (
23f0bab
) to head (d750f87
). Report is 23 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
some unittests moved to https://github.com/OpenVoiceOS/OVOS-workshop/pull/235
brings support for ovos-workshop 1.0.0 , it removed support for running UNDER mycroft-core, this was a breaking change in some imports under the mycroft namespace
Summary by CodeRabbit
New Features
mycroft
module, encouraging transition toovos_core
.Bug Fixes
FallbackMode
to ensure proper functionality within the fallback service.Chores