logs/end_of_track

[JarbasAl]

make it easier to debug issues like https://github.com/OpenVoiceOS/ovos-ocp-audio-plugin/issues/123

companion to https://github.com/OpenVoiceOS/ovos-audio-plugin-mpv/pull/6

2024-08-06 19:18:19.439 - audio - ovos_plugin_mpv:handle_track_end:54 - DEBUG - MPV playback start
2024-08-06 19:18:19.444 - audio - ovos_audio.audio:track_start:212 - DEBUG - New track coming up!
2024-08-06 19:18:19.505 - audio - ovos_plugin_common_play.ocp.player:handle_player_media_update:744 - DEBUG - backend=<PlaybackType.AUDIO_SERVICE: 3>|msg_type=ovos.common_play.media.state
2024-08-06 19:23:53.679 - audio - ovos_plugin_mpv:handle_track_end:58 - DEBUG - MPV playback ended
2024-08-06 19:23:53.683 - audio - ovos_audio.audio:track_start:219 - DEBUG - End of playlist!
2024-08-06 19:23:53.701 - audio - ovos_plugin_common_play.ocp.player:handle_player_media_update:744 - DEBUG - backend=<PlaybackType.AUDIO_SERVICE: 3>|msg_type=ovos.common_play.media.state
2024-08-06 19:23:53.702 - audio - ovos_plugin_common_play.ocp.player:handle_player_state_update:717 - INFO - PlayerState changed: <PlayerState.STOPPED: 0>
2024-08-06 19:23:53.703 - audio - ovos_plugin_common_play.ocp.player:handle_player_media_update:756 - DEBUG - MediaState changed: <MediaState.END_OF_MEDIA: 7>
2024-08-06 19:23:53.705 - audio - ovos_plugin_common_play.ocp.player:handle_playback_ended:772 - INFO - END OF MEDIA - playlist pos: 0 total tracks: 9 backend: 3
2024-08-06 19:23:53.707 - audio - ovos_plugin_common_play.ocp.player:handle_playback_ended:778 - DEBUG - Go to Next track: True
2024-08-06 19:23:53.709 - audio - ovos_plugin_common_play.ocp.player:pause:578 - DEBUG - Pausing playback: 3
2024-08-06 19:23:53.716 - audio - ovos_plugin_common_play.ocp.player:set_now_playing:251 - DEBUG - Playing: PluginStream(stream='https://music.youtube.com/watch?v=YXM1W0LOT8o', extractor_id='youtube', title='Rastejantes', artist='Xeque Mate', match_confidence=83.91304347826087, skill_id='skill-ovos-youtube-music.openvoiceos', playback=2, status=1, media_type=2, length=317000, image=None, skill_icon='/home/miro/PycharmProjects/ovos-core/.venv/lib/python3.11/site-packages/skill_ovos_youtube_music/res/ytmus.png')
2024-08-06 19:23:58.615 - audio - ovos_plugin_common_play.ocp.player:set_now_playing:266 - INFO - PluginStream extracted: MediaEntry(uri='https://rr1---sn-ovn-v2v6.googlevideo.com/videoplayback?expire=1722990234&ei=OmqyZv_3LtbVp-oPseKF8Ak&ip=89.154.90.167&id=o-AIfkRAsWehJXo-yQSusPnyzUtHiFg61eZ1hNqNwg5xm0&itag=251&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=Z7&mm=31%2C29&mn=sn-ovn-v2v6%2Csn-ovn-apnk&ms=au%2Crdu&mv=m&mvi=1&pl=20&gcr=pt&initcwndbps=1532500&bui=AXc671JihEiQHw4HuhH6aPllsuXFFpYJ1h_7gBSo25fZp9zMiO_tU3yw_OCV9QbiqIT6tG52QTaXl9wy&spc=Mv1m9jQqYd7hJ8d1NWsgniMP3GAfAlcQsNfDjVO870bA6_gDt-ay&vprv=1&svpuc=1&mime=audio%2Fwebm&ns=X-jcX5upR0TtQKX38aGhUn4Q&rqh=1&gir=yes&clen=5279568&dur=316.461&lmt=1714684464124773&mt=1722968245&fvip=2&keepalive=yes&c=WEB_CREATOR&sefc=1&txp=2318224&n=iRn54Oq0NY3KNg&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cgcr%2Cbui%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Crqh%2Cgir%2Cclen%2Cdur%2Clmt&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AGtxev0wRAIfBRxPhYQrUQUSz40NggXQm45NOKgJfgg4wNWtgsUuoQIhANWmhHMAcBWAHkqS4pLJMpBouMmHvgUKJw_OcyYXJHqy&sig=AJfQdSswRgIhAMA86ns1DbqraccylWH9aXtxWuCGA9uvgkO1r_paIAT7AiEAuxcA3bJx4FyQsmFNhnKj09PrSBrKAbS4-0o0ltfSUL0%3D', title='Rastejantes', artist='Xeque Mate - Topic', match_confidence=83.91304347826087, skill_id='skill-ovos-youtube-music.openvoiceos', playback=2, status=1, media_type=2, length=317000, image='https://i.ytimg.com/vi_webp/YXM1W0LOT8o/maxresdefault.webp', skill_icon='/home/miro/PycharmProjects/ovos-core/.venv/lib/python3.11/site-packages/skill_ovos_youtube_music/res/ytmus.png', javascript='')
2024-08-06 19:23:58.619 - audio - ovos_plugin_common_play.ocp.player:play_next:528 - INFO - Next track index: 1
2024-08-06 19:24:01.768 - audio - ovos_plugin_common_play.ocp.player:validate_stream:327 - DEBUG - Casting to PlaybackType.AUDIO_SERVICE

Summary by CodeRabbit

• New Features

  • Enhanced logging for media playback state at the end of playback, providing detailed insights into the playlist and backend.
  • Improved logic to ensure the next track exists before attempting to play it, enhancing playback robustness.

• Bug Fixes

  • Refined conditions for autoplay and playlist management to prevent errors related to out-of-bounds access.

[coderabbitai[bot]]

Walkthrough

The recent modifications to the handle_playback_ended method enhance media playback control and logging. The updates clarify the logic for transitioning to the next track by ensuring that it only proceeds if a subsequent track exists. Enhanced logging captures the playlist state and active backend at the end of playback, improving visibility into the playback process and contributing to overall robustness and maintainability.

Changes

Files	Change Summary
ovos_plugin_common_play/...	Refined playback control logic and enhanced logging in the handle_playback_ended method.

Poem

In the meadow where the playlists play,
A rabbit hops, brightening the day.
With logs that sparkle and tracks that flow,
Autoplay sings, delight in the show!
Hooray for changes that make it right,
Let’s dance to the music, oh what a sight! 🐇🎶

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.