search

OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

sing: more voice support #46

Open JarbasAl opened 3 months ago

JarbasAl commented 3 months ago

if using the SAM TTS, we could also have songs! having SAM in the first place already feels like a easter egg :)

mikejgray commented 5 days ago

Checking for SAM usage is easy:

    def _sounds_like_sam(self) -> bool:
        tts = self.config_core.get("tts", {})
        if "sam" in tts.get("module", "").lower():
            return True
        return False

But playing YouTube videos is more complex...we'd have to do a lot of validation to see if we can use it through OCP/media. I don't see contact information for Noplan so no easy way to ask permission to get just the audio and provide an attribution link.

Thoughts on how to proceed, @JarbasAl ?

JarbasAl commented 5 days ago

i'd just download the track and then bundle it with the skill, guess we should ask the author in this case, if it was a remote url we wouldnt need pemission but to bundle it we should reach out

mikejgray commented 4 days ago

I thought about that but there is no contact information for this channel that I could find...

JarbasAl commented 4 days ago

I thought about that but there is no contact information for this channel that I could find...

if you cant ask for permission, ask for forgiveness :man_shrugging: leave a note on the readme with clear attribution and an offer to take it down