OpenVoiceOS / ovos-skill-youtube

play music from youtube in mycroft
Apache License 2.0
5 stars 6 forks source link

Incompatible with latest version of ovos-workshop #5

Closed theCalcaholic closed 3 years ago

theCalcaholic commented 3 years ago

Since your other skills, especially skill-better-playback-control rely on version 0.0.3a1 of ovos-workshop by now, it would probably be a good idea to update this skill as well. As far as I can see, it is enough to adjust a few imports:

-from ovos_workshop.skills.common_play import BetterCommonPlaySkill
-from ovos_workshop.frameworks.cps import CPSMatchType, CPSPlayback
+from ovos_workshop.skills.common_play import OVOSCommonPlaybackSkill as BetterCommonPlaySkill
+from ovos_workshop.frameworks import CPSMatchType, CPSPlayback

However, since the skill doesn't work for me yet, I can't test the changes either (otherwise, I would have sent you a PR).