OpenVoiceOS / skill-ovos-weather

OpenVoiceOS official Weather Skill, providing weather conditions and forecasts.
Apache License 2.0
1 stars 4 forks source link

Fix Spanish translations #41

Closed atd closed 1 year ago

atd commented 1 year ago

I kept the order in date-time folder. I guess it matters?

I also changed the sentences for using words instead of adjectives, as I saw in dialog/condition. However, they will sound weird if using adjectives (which can be found in vocabulary/condition)

emphasize commented 1 year ago

please also translate https://github.com/atd/skill-ovos-weather/blob/staging/translation_es-es/locale/es-es/regex/location.rx regex is too nasty to autotranslate

emphasize commented 1 year ago

I kept the order in date-time folder. I guess it matters?

what do you mean by that?

However, i think you have to review number-days.voc again. This is the part of the intent that signifies the span of the weather report like en_us

2 day
two day
next 2 days
next two days
next couple of days
next couple days

autotranslate got them mixed up, so its harder to see the pattern.

rerlative-day = one day report relative from now relative-time = report for the time of day (Lingua franca defines them here)

_A tricky thing to know, since it doesn't matter what you would like to say, but what is defined there, i.e the utterance gets parsed by extract_datetime to determine the hour of the report Similarly for number-days, which gets extracted by extract_number, so it has to contain a spoken/written number (couple=2 in en)_

atd commented 1 year ago

please also translate https://github.com/atd/skill-ovos-weather/blob/staging/translation_es-es/locale/es-es/regex/location.rx

done. But I am not totally sure of the order. May I have an example of a phrase to match?

However, i think you have to review number-days.voc again. This is the part of the intent that signifies the span of the weather report

Yes, that is what I was asking about. I fixed the order because I saw them pretty ordered in the original

I don't understand "2 day" though. Is it 2nd day? Why day is in singular?

next couple of days etc... I think they are fine in the review

emphasize commented 1 year ago

Sorry, had a little detour to test location intents.

2 day is just a short for the the next two days, as in a "2 day weather report"

When you're confident with the changes, i'd merge into #40

atd commented 1 year ago

Updated!

I cannot say it will perfect, but maybe with use I will be able to tune it