OpenVoiceOS / zzz-old-ovos-utils

collection of simple utilities for use across the mycroft ecosystem
Apache License 2.0
4 stars 2 forks source link

stop input returns multiple errors #41

Closed goldyfruit closed 3 years ago

goldyfruit commented 3 years ago

When using the stop command from the CLI it returns an error on 4 different skills.

I'm using the dev version with the latest commit.

image

Errors from the skills.log:

2021-02-06 02:57:32.214 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Playback Control Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.247 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Joking Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.252 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in Timer Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
2021-02-06 02:57:32.254 - OVOS - ovos_utils.waiting_for_mycroft.base_skill:on_error:155 - ERROR - An error occurred while processing a request in News Skill
Traceback (most recent call last):
  File "/home/mycroft/core/mycroft/skills/mycroft_skill/event_container.py", line 66, in wrapper
    handler(message)
  File "/opt/mycroft-venv/lib/python3.7/site-packages/ovos_utils/waiting_for_mycroft/base_skill.py", line 184, in __handle_stop
    super().__handle_stop()
TypeError: __handle_stop() missing 1 required positional argument: '_'
ChanceNCounter commented 3 years ago

I can see where we aren't passing the param along, but I can't seem to repro, so I'm gonna take this in steps. First step, try passing the param along =P

ChanceNCounter commented 3 years ago

@goldyfruit ostensible fix branch is bug/handle_stop

goldyfruit commented 3 years ago

@goldyfruit ostensible fix branch is bug/handle_stop

The fix works for me, this is the log output when I use the stop utterance:

2021-02-06 17:59:40.162 | DEBUG    |     1 | mycroft.skills.intent_service:_normalize_all_utterances:73 | Utterances: [('stop',)]
2021-02-06 17:59:40.173 | DEBUG    |     1 | mycroft.skills.intent_service:_normalize_all_utterances:73 | Utterances: [('stop',)]
2021-02-06 17:59:40.177 | DEBUG    |     1 | mycroft.skills.intent_services.padatious_service:_match_level:179 | Padatious Matching confidence > 0.95
2021-02-06 17:59:40.568 | DEBUG    |     1 | mycroft.skills.intent_services.padatious_service:_match_level:179 | Padatious Matching confidence > 0.95
2021-02-06 17:59:40.805 | INFO     |     1 | Playback Control Skill | Audio service status: {}

Thanks @ChanceNCounter