OpenWebAdvocacy / website

Source code for the Open Web Advocacy website.
https://open-web-advocacy.org/
MIT License
33 stars 24 forks source link

Add basic accessible language switcher dialog #173

Closed sbesh91 closed 3 weeks ago

sbesh91 commented 1 month ago

This PR adds a language switcher dialog to the site. The emphasis is on making it keyboard and screen reader accessible instead of over-styled.

netlify[bot] commented 1 month ago

Deploy Preview for owa-production ready!

Name Link
Latest commit 26312ffb5ee768da65f5ce13d86074c30641d0ea
Latest deploy log https://app.netlify.com/sites/owa-production/deploys/6723e96e1868b600085dee97
Deploy Preview https://deploy-preview-173--owa-production.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mtom55 commented 1 month ago

Couple of changes:

The selection of languages should be in the original language for each selection image

or optionally English / English Espanol / Spanish

and the image should also be in the language.

and I was thinking if we could add a grey world icon like in the OWA logo to the left of the text.

sbesh91 commented 1 month ago

Couple of changes:

The selection of languages should be in the original language for each selection image

or optionally English / English Espanol / Spanish

and the image should also be in the language.

and I was thinking if we could add a grey world icon like in the OWA logo to the left of the text.

Yeah, I think all of that is reasonable and doable.

mtom55 commented 1 month ago

I meant more like a globe like https://fontawesome.com/icons/globe?f=classic&s=light (if we can find a royalty free version) rather than the OWA logo, and on the home page rather than the pop-up dialog

sbesh91 commented 1 month ago

I meant more like a globe like https://fontawesome.com/icons/globe?f=classic&s=light (if we can find a royalty free version) rather than the OWA logo, and on the home page rather than the pop-up dialog

I understand now. I'll get that updated.

mtom55 commented 4 weeks ago

This page still needs each option in it's original language:

image

i.e. instead of: English Spanish

it should be

English Español. Languages and close can be in the current language that is set.

image

To the left of the language selector we should also have the icon on the menu:

image
mtom55 commented 3 weeks ago

Looks great!