Closed tklengyel closed 6 years ago
Yes, sounds like it is necessary.
On Tue, Mar 13, 2018, 11:13 AM Tamas K Lengyel notifications@github.com wrote:
@tklengyel commented on this pull request.
In do_build.sh https://github.com/OpenXT/openxt/pull/285#discussion_r174168644:
@@ -925,8 +930,19 @@ generic_do_installer_iso()
cp -r "$repository/"* "$iso_path"
- echo " - create efiboot.img"
- dd if=/dev/zero bs=1M count=5 of=${EFIBOOTIMG}
- /sbin/mkfs.fat ${EFIBOOTIMG}
- mkdir -p efi_tmp
- fusefat -o rw+ ${EFIBOOTIMG} efi_tmp
- mkdir -p efi_tmp/EFI/BOOT
- cp -f "$path/grubx64.efi" efi_tmp/EFI/BOOT/BOOTX64.EFI
- sync
- fusermount -u efi_tmp
- rm -rf efi_tmp
In that case it looks to me keeping the additions in do_build.sh as well is necessary.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenXT/openxt/pull/285#discussion_r174168644, or mute the thread https://github.com/notifications/unsubscribe-auth/ABysv6ZGQB1VdC5BauRatHbu2mDGz5Bnks5td-IMgaJpZM4ShffL .
Merging soon.
This PR includes the changes necessary for building OpenXT with UEFI support. The two major changes are the splitting of the
openxt-installer
into its own machine type and usingxorriso
to build an ISO image bootable both under legacy and UEFI.Related PRs: https://github.com/OpenXT/xenclient-oe/pull/828 https://github.com/OpenXT/installer/pull/63