search

OpenXT / openxt

Base OpenXT build scripts
48 stars 39 forks source link

STABLE-8: OXT-1346: xen: Move version management to the recipes. #313

Closed eric-ch closed 6 years ago

eric-ch commented 6 years ago

xen-common.inc is directly using these variables, it should be easier to handle everything from the same place.

jandryuk commented 6 years ago

I am in favor of this change and want it to go in. This looks like it breaks pkg-xctools/build.sh:make_bundle_xctools() which references ${XEN_VERSION} and ${XEN_SRC_URI}. Does anyone still use that, or should it be dropped? Users can just install the distro provided xenstore-utils.

eric-ch commented 6 years ago

@jandryuk My bad that is one of the scripts I did not try. The public builder no longer does that either. It creates distribution packages with the xenstore-utils (or equivalent) package as dependency. This should be doable in this case as well by adding the dependency to the debian/rpm package metadata.

jandryuk commented 6 years ago

I don't use xctools, so I am okay with just removing it.

eric-ch commented 6 years ago

@jandryuk Actually, I prefer that too :). This bundle of things made as one package is dubious at best.

jean-edouard commented 6 years ago

May I request a small -f test there too? :) https://github.com/OpenXT/openxt/blob/stable-8/build-scripts/oe/build.sh#L46

eric-ch commented 6 years ago

Latest changes should remove the xenstore-tools contraption. Also added the check required in build-scripts.

The pkg-tools scripts look very broken. I am not too sure how the RHEL/CentOS versions can still work. Maybe it is time to remove them entirely if they are no longer used.

jean-edouard commented 6 years ago

Built here: http://openxt-builder.ainfosec.com:8010/builders/openxt/builds/1556

jean-edouard commented 6 years ago

LGTM, merging soon.