Openxt client tool install signing for 18.04+

OpenXT / openxt

Base OpenXT build scripts

48 stars 39 forks source link

Closed ianmclinden closed 6 years ago

ianmclinden commented 6 years ago

Add source as trusted before install to allow install without disabling apt source signing.

Tested on Ubuntu 18.04

jandryuk commented 6 years ago

Oh, one thing. Does this break older clients?

ianmclinden commented 6 years ago

I'll test Ubuntu 16.04 and deb 7.11.0 / 8.10.0 later today.

ianmclinden commented 6 years ago

Tested and working on:

Debian 7.11 / 3.2.0-6-amd64
- Script did not work - with and without the change
- Error: No directory /etc/modules-load.d/
- Created /etc/modules-load.d and reran - works with and without changes
Debian 8.10 / 3.16.0-4-amd64
Debian 9.4.0 / 4.9.0-6-amd64
Ubuntu 16.04 / 4.10.0-28-generic
Ubuntu 18.04 / 4.15.0-22-generic

eric-ch commented 6 years ago

@ianmclinden Indeed, https://github.com/OpenXT/openxt/blob/master/build-scripts/debian/install.sh#L47 assumes systemd-module-load.service is in use, with /etc/modules-load.d. 7.11 may be using /etc/modules[.conf] with sysvinit?

Tracked under: OXT-1348

jandryuk commented 6 years ago

Thanks, @ianmclinden

jean-edouard commented 6 years ago

Merging soon.