`EIP712Upgradeable` - Adjust storage gaps to 50

OpenZeppelin / openzeppelin-contracts-upgradeable

Upgradeable variant of OpenZeppelin Contracts, meant for use in upgradeable contracts.

https://openzeppelin.com/contracts

MIT License

1k stars 436 forks source link

`EIP712Upgradeable` - Adjust storage gaps to 50 #174

Closed shunkakinoki closed 2 years ago

shunkakinoki commented 2 years ago

Apologies in advance if this is an intended implementation - was scrolling through the source code, and wondered why the gap was still [50] when 2 storage slots was declared in the EIP712Upgradeable

PR Checklist

[ ] Tests
[ ] Documentation
[ ] Changelog entry

frangio commented 2 years ago

It's hardcoded to be that way:

https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/54803be62207c2412e27d09325243f2f1452f7b9/contracts/utils/cryptography/draft-EIP712Upgradeable.sol#L28

This is for backwards compatibility related to an issue we had. See https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/security/advisories/GHSA-7j52-6fjp-58gr