search

OpenwaterHealth / OpenLIFU-python

focused ultrasound toolbox
GNU Affero General Public License v3.0
12 stars 2 forks source link

Add virtual fit options to Protocol #165

Open ebrahimebrahim opened 1 week ago

ebrahimebrahim commented 1 week ago

pitch and yaw ranges should come from the Protocol, as they are determined by the target's general location. I think it's ok for virtual fitting to take them as inputs (as opposed to taking the whole Protocol), but their values in operation should come from the Protocol.

_Originally posted by @peterhollender in https://github.com/OpenwaterHealth/OpenLIFU-python/pull/162#discussion_r1848790409_

Add virtual fit options (perhaps VirtualFitOptions similar to SolutionAnalysisOptions) to Protocols

They would contain pitch_range, pitch_step, yaw_range, yaw_step, search_range_units

Depends on #162

ebrahimebrahim commented 1 week ago

@peterhollender Before the MRI volume is input into the virtual fit algorith, it is reasampled into a transducer based coordinate grid (lat, ele, ax), right? To determine the spacing of that grid, I imagine we shouldn't use the Protocol's SimSetup, because one may want to use different volume resolutions for simulation versus virtual fitting. So do you agree that a separate virtual fit "coords" should be part of the virtual fit options?

Forget my question here -- the volume does not need to be resampled at all for the virtual fit algorithm. It can go in at full resolution, the raw volume array (converted to LPS) is fine.