OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
371 stars 267 forks source link

initial ts setup. changed pages/*.js to pages/*.tsx #1792

Closed billy-le closed 9 months ago

billy-le commented 9 months ago

Description of changes

introduce typescript with initial setup. pages dir files converted to typescript.

Issue Resolved

Fixes #1721

Screenshots/GIFs

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:21am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:21am
cypress[bot] commented 9 months ago

Passing run #4609 ↗︎

0 24 0 0 Flakiness 0

Details:

remove prop-types from .ts, .tsx files
Project: operation_code Commit: d993d9071f
Status: Passed Duration: 02:59 💡
Started: Feb 16, 2024 4:22 AM Ended: Feb 16, 2024 4:25 AM

Review all test suite changes for PR #1792 ↗︎

billy-le commented 9 months ago

Not sure what the scope of this issue is but I think we should add typescript incrementally. Here I just set up an initial setup with a few changes to the pages dir. We can open up other issues to convert Components since those are most likely to take the longer to transition to ts.

billy-le commented 9 months ago

Most of the issues are now resolved

image

Let me know if there is anything else you would like for me to include.

kylemh commented 9 months ago

don't forget to remove prop types from all the files you converted. any initial prop values can be switched to default values within the params of the function.

billy-le commented 9 months ago

okay, i think i got them all

codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit d993d907 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 74.1% (-0.7% change).

View more on Code Climate.

recondesigns commented 9 months ago

What is the latest here? Is there a list of components/pages that need to to be converted to TS?

billy-le commented 9 months ago

this is just the initial set up of typescript. i believe that migrating individual components would be a separate pr.

recondesigns commented 9 months ago

this is just the initial set up of typescript. i believe that migrating individual components would be a separate pr.

Right on. I didn't want to start working on any components until the TS setup was merged in so that I could branch off that. Was curious if you were still working this, or if it was just waiting for someone to approve the merge (despite the codeclimate not passing).

kylemh commented 9 months ago

great work @billy-le - thanks!