OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
371 stars 267 forks source link

replaced jest with vitest #1798

Closed billy-le closed 9 months ago

billy-le commented 9 months ago

Description of changes

Replacing Vitest with Jest for a faster test runner and compatibility with Vite whenever it's implemented

Issue Resolved

Fixes #1727

Screenshots/GIFs

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 8:38am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 8:38am
cypress[bot] commented 9 months ago

Passing run #4630 ↗︎

0 25 0 0 Flakiness 0

Details:

fixed missing jest-dom types
Project: operation_code Commit: afbde599b1
Status: Passed Duration: 03:10 💡
Started: Feb 29, 2024 8:39 AM Ended: Feb 29, 2024 8:42 AM

Review all test suite changes for PR #1798 ↗︎

kylemh commented 9 months ago

You'll have a merge conflict now presumably. I merged the other PR first so I could see that this PR worked with TS first!

codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit afbde599 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 80.6% (6.5% change).

View more on Code Climate.

billy-le commented 9 months ago

i really don't know. if we start converting cypress js to ts, do you think it will be needed?

kylemh commented 9 months ago

Nah. Plan there would be to use Playwright instead of Cypress going forward. Regarding the babel config, I guess it doesn't hurt to have so I'll leave it alone.