search

OrderedChaos-Dev / ProjectVibrantJourneys

Minecraft mod that expands in all directions
37 stars 15 forks source link

Sea Oats placeable blocks are hardcoded #111

Closed MaxNeedsSnacks closed 3 years ago

MaxNeedsSnacks commented 4 years ago

https://github.com/OrderedChaos-Dev/ProjectVibrantJourneys/blob/e74eea9e8fe96631aea3097f1f90b88e2338135b/src/main/java/projectvibrantjourneys/common/blocks/SeaOatsBlock.java#L25

Preferably, you'd either use instanceof checks here to make sure it can be planted on other blocks that extend DirtBlock (for instance, BoP dirt types) or make a tag (á la vanilla #minecraft:bamboo_plantable_on) to make it configurable through datapacks which blocks plants should be able to be placed on

OrderedChaos-Dev commented 4 years ago

Ah yes, sometimes I just type out my thoughts when adding behavior to blocks and forget to actually account for things like this. I'll take a look at the pr and put together a patch

OrderedChaos-Dev commented 3 years ago

I saw the pr, I'm going to go for checking the block's material instead of tags to keep it small.