search

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin
MIT License
81 stars 33 forks source link

create a fix for transaction hash #596

Closed sparrowDom closed 5 years ago

sparrowDom commented 5 years ago

Description:

Fixes a bug in contract service

sparrowDom commented 5 years ago

Good news just testing this on the Mainnet, and while we do show an error in our modal, the confirmation workaround with this PR fix works on Metamask 4.12.0. See the transactions dropdown in the backgroud.

screenshot 2018-10-03 23 04 14

I think this is good to merge @franckc!

sparrowDom commented 5 years ago

Oh yeah and as expected Metamask still fumbles and throws its inner errors. We can solve the DApp modal error with some sort of try catch as Stan suggested

franckc commented 5 years ago

Thanks for testing @sparrowDom - going to merge now....