Closed garrett361 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.2%. Comparing base (
515166b
) to head (5540ea3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The error you got is because you haven't cloned the plenary repo. Previously it worked without it when using packer but if you use lazy this won't work. So the easiest thing should just be to clone it down in the project root (GitHub workflow file does this).
Yep, will do! Didn’t want to add one until I sanity checked with you that this looked fine. Thanks!
Okay, added a fix so it will clone done plenary before testing #124
@OscarCreator I added a (pretty minor) test. LMK if you want something more extensive. Unrelated tests were failing on my mac (I see the same for #124).
And fixed the linting issues
Hi, great plugin! Just a tiny PR to handle commented out lines in ignore files. Tested locally. I have not yet been able to run
make test
successfully:But I think it should be easy enough to add automated tests once I get the environment fixed.
Does this look good, otherwise?