OscarCreator / rsync.nvim

neovim plugin which synchronises project with rsync on save.
MIT License
83 stars 12 forks source link

ignore comments in ignore files #123

Closed garrett361 closed 7 months ago

garrett361 commented 8 months ago

Hi, great plugin! Just a tiny PR to handle commented out lines in ignore files. Tested locally. I have not yet been able to run make test successfully:

nvim --headless --noplugin -u /Users/garrett/github/garrett361/rsync.nvim/scripts/minimal.vim -c "PlenaryBustedDirectory /Users/garrett/github/garrett361/rsync.nvim/tests/rsync/ {minimal_init = '/Users/garrett/github/garrett361/rsync.nvim/tests/minimal_init.lua'}"
Error detected while processing command line:
E492: Not an editor command: PlenaryBustedDirectory /Users/garrett/github/garrett361/rsync.nvim/tests/rsync/ {minimal_init = '/Users/garrett/github/garrett361/rsync.nvim/tests/minimal_init.lua'}^Cmake: *** [test] Interrupt: 2

But I think it should be easy enough to add automated tests once I get the environment fixed.

Does this look good, otherwise?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.2%. Comparing base (515166b) to head (5540ea3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ====================================== Coverage 94.2% 94.2% ====================================== Files 5 5 Lines 332 333 +1 ====================================== + Hits 313 314 +1 Misses 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OscarCreator commented 8 months ago

The error you got is because you haven't cloned the plenary repo. Previously it worked without it when using packer but if you use lazy this won't work. So the easiest thing should just be to clone it down in the project root (GitHub workflow file does this).

garrett361 commented 8 months ago

Yep, will do! Didn’t want to add one until I sanity checked with you that this looked fine. Thanks!

OscarCreator commented 8 months ago

Okay, added a fix so it will clone done plenary before testing #124

garrett361 commented 7 months ago

@OscarCreator I added a (pretty minor) test. LMK if you want something more extensive. Unrelated tests were failing on my mac (I see the same for #124).

garrett361 commented 7 months ago

And fixed the linting issues