search

OscarGodson / EpicEditor

EpicEditor is an embeddable JavaScript Markdown editor with split fullscreen editing, live previewing, automatic draft saving, offline support, and more. For developers, it offers a robust API, can be easily themed, and allows you to swap out the bundled Markdown parser with anything you throw at it.
http://epiceditor.com
MIT License
4.25k stars 334 forks source link

Ticket #268 - potential fix to whitespace issues #269

Closed Gankra closed 11 years ago

Gankra commented 11 years ago

Here's the proposed fix. I've tested against all our target browsers (personal eyeball tests and unit tests), and have it staged for production in my deployment as a hotfix.

I will not be writing unit tests, as I'm currently a bit busy, but I have posted recommendations for unit tests you may want to write in #268, should you want to start testing this behaviour.

Gankra commented 11 years ago

What are the odds of getting this merged and released by wednesday? Evidently we're under a bit more pressure than I thought to ship something for demo purposes. No one here wants to ship a tweaked fork of a third-party lib, and this is a pretty major bug if it's repro-ing on other machines.

OscarGodson commented 11 years ago

Yeah, I was able to repro it too. I'm at OSCON today. I'll test it at lunch!

OscarGodson commented 11 years ago

@Gankro If anything, this makes everything simpler and works more consistently across browsers. There's one odd thing in IE9 and 10 tho. Clear localstorage and start fresh. Type some text (notice the big gap above the text). Now refresh. Text moves closer to top of editor.

OscarGodson commented 11 years ago

Oh, and this is merged by the way

Gankra commented 11 years ago

Yeah that seems to be a thing with how IE treats divs vs brs. I think it does new lines with divs by default, whereas we use brs.