OttoDIY / blockly

Otto Blockly; a fully integrated graphical programming for any type of Arduino projects, including robots, ready to install in your computer, it works offline and also online
https://www.ottodiy.com/software
GNU General Public License v2.0
113 stars 80 forks source link

optimized the german translation in Arduino_de.js and Blockly_de.js #181

Closed Kimosaj closed 1 year ago

Kimosaj commented 1 year ago

Hello I'm very interested in this project and wanted to help translating this in to my native language German. So here is my first commit, but it is not finished yet. I will commit more changes in the next weeks.

These are the changes I made for now:

P.S.: My Prettier addon in VS Code made some changes to the layout of the code. I hope these changes are ok. :smile:

Kimosaj commented 1 year ago

Status of my work:

Arduino_de.js sections:

cparrapa commented 1 year ago

@Kimosaj great initiative you might want to look at this other PR https://github.com/OttoDIY/blockly/pull/163 maybe we can combine it with yours so that we can merge all?

Thanks

Kimosaj commented 1 year ago

@Kimosaj great initiative you might want to look at this other PR #163 maybe we can combine it with yours so that we can merge all?

Thanks

@cparrapa I saw this Request but because there wasn´t anything done since April I thought this request is outdated.

cparrapa commented 1 year ago

you are right @Kimosaj might have been abandoned by @DiWoWet

Kimosaj commented 1 year ago

you are right @Kimosaj might have been abandoned by @DiWoWet

@cparrapa so what to do know? I mean would be a pity if the stuff whats was finished by @DiWoWet would´nt be implemented. But I dont know how to merge this into my work.

DiWoWet commented 1 year ago

Hey guys, I'm sorry to tell you that I simply forgot working on the translation and finishing it. There were only minor issues and I think that I am going to have another look at it until new years eve.

Richtig dumm gelaufen und richtig unangenehm. :D :D :D

Kimosaj commented 1 year ago

@cparrapa I finally found the time again to keep working on the translation. Today I tried to build the app with the translation I made so far to look if everything is how I expected. But because I have no experience with building apps from source code I ran into some trouble with errors. I f I want to execute npm install there is this error: npm ERR! code EJSONPARSE npm ERR! JSON.parse Failed to parse json npm ERR! JSON.parse Unexpected token / in JSON at position 751 while parsing near '...--win --ia32", npm ERR! JSON.parse //"compiler": "build...' npm ERR! JSON.parse Failed to parse package.json data. npm ERR! JSON.parse package.json must be actual JSON, not just JavaScript.

cparrapa commented 1 year ago

not sure what that error means @Kimosaj but what you can do is just attach the _de.js and i can add those changes for next release that we plan to make this month, otherwise you will have to wait for next release for the changes to be added

Kimosaj commented 1 year ago

@cparrapa I can't attach the single file to a comment. Is it possible to merge this pull request even it is in draft? If yes I have to merge my branch where I'm working on to my linked master-branch.

cparrapa commented 1 year ago

Hi @Kimosaj
Github says "This pull request is still a work in progress. Draft pull requests cannot be merged."

So you have to update your main branch and I will wait for your PR and we can merge even if is not completely ready

Kimosaj commented 1 year ago

@cparrapa finally finished all the translation :smile: :+1:

cparrapa commented 1 year ago

Thanks good job! @Kimosaj merging now