search

OttoStruve / muler

A Python package for working with pipeline-produced spectra from IGRINS, HPF, and Keck NIRSPEC
https://muler.readthedocs.io
MIT License
15 stars 9 forks source link

Possible Windows Issue? #58

Closed gully closed 3 years ago

gully commented 3 years ago

Working with @18ganesha we have discovered what seems to be a platform-dependent muler bug. sky_subtract() raises a units error, which we thought was an astropy version problem, but we installed a fresh conda environment using the provided muler_dev python environment.yml file, and the problem persisted. Weird! The unit tests pass with some failures so that's a good place to look.

My hunch is that there is something wrong with the importlib resources approach that may go awry in Windows? I have a Windows dual-boot that I can use to test this out, so the task is:

gully commented 3 years ago

Ok, I successfully installed and ran sky_subtract() on a Windows computer, with a fresh conda environment and the latest version of main.
I was also available to verify the Keck NIRSPEC unit test failures because we split the filename on OS-specific back-slashes. I should be able to fix that momentarily...