As part of creating an EchelleSpectrum class, we want to refactor the HPF spectrum class. Here are some tasks:
[x] Should sky subtract accept a sky flux vector or an HPFSpectrum class? It currently takes a vector assumed to be the same length.
[x] blaze_subtract_spline should propagate the blaze correction into the uncertainty.
[ ] Standardize docstrings to either numpy style or Google style but not both. Probably numpy style?
[ ] Add parameters descriptor for all input parameters for new methods
[ ] Consider renaming time_edges to trim_edges_by_x or something to emphasize that the operation is on the original x coordinate, regardless of previous destructive operations.
[x] How to handle the sky and LFC fibers--- which methods don't make sense anymore?
[x] Add some attributes specific to HPF: a goldilocks or instrument_team flag, etc.
[x] Alter the cached_HDUs kwarg to handle just one input spectrum, rather than the two needed for IGRINS.
[x] Add back support for cached_HDU mimicking IGRINS
As part of creating an
EchelleSpectrumclass, we want to refactor the HPF spectrum class. Here are some tasks:HPFSpectrumclass? It currently takes a vector assumed to be the same length.blaze_subtract_splineshould propagate the blaze correction into the uncertainty.parametersdescriptor for all input parameters for new methodstime_edgestotrim_edges_by_xor something to emphasize that the operation is on the original x coordinate, regardless of previous destructive operations.goldilocksorinstrument_teamflag, etc.cached_HDUskwarg to handle just one input spectrum, rather than the two needed for IGRINS.cached_HDUmimicking IGRINS