search

Oufattole / meds-torch

MIT License
16 stars 2 forks source link

Is the max seq len constraint not respected if postpend EOS or prepend static is enabled? #95

Closed mmcdermott closed 1 month ago

mmcdermott commented 1 month ago

@Oufattole, how is this accounted for currently? Couldn't the current code have an issue with this?

mmcdermott commented 1 month ago

This was only partially true -- the EOS case was handled by a resolver, but that is likely erroneous, and will be captured in #99