Avoid FutureWarning for `dt.week` - Githubissues

Ouranosinc / xclim

Library of derived climate variables, ie climate indicators, based on xarray.

https://xclim.readthedocs.io/en/stable/

Apache License 2.0

333 stars 59 forks source link

Avoid FutureWarning for `dt.week` #1964

Closed aulemahal closed 1 month ago

aulemahal commented 1 month ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug fixes / features)
[ ] CHANGELOG.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Changes the dt.week call to dt.isocalendar().week to avoid an (ancient) FutureWarning from xarray.

Does this PR introduce a breaking change?

No. all xarray versions we support have the isocalender() accessor.

Other information: