Fix all-nan slices in ExtremeValues - Githubissues

Ouranosinc / xclim

Library of derived climate variables, ie climate indicators, based on xarray.

https://xclim.readthedocs.io/en/stable/

Apache License 2.0

333 stars 59 forks source link

Fix all-nan slices in ExtremeValues #1983

Closed coxipi closed 4 weeks ago

coxipi commented 4 weeks ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug fixes / features)
[x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

All-nan slices were previously broken in _extremes_train_1d, now there is a fast-track that treats all-nan separately.

Does this PR introduce a breaking change?

No

Other information: