Closed coxipi closed 6 days ago
But if q
is the most common standard, why would we not use that ?
But if
q
is the most common standard, why would we not use that ?
I just thought that the variable associated with the streamflow should have its standard naming declared with units in variables.yml
. Then, if we define q
as a streamflow in variables.yml
, I'm not sure it's a good idea to use it as a variable for quantiles, no?
Most references to q
as "quantile" I see in xclim are in sdba
, where I would assume context is enough to make the difference ? There are no indicators that refer to quantiles as q
, only xc.indices.stats.parametric_quantile
does it and I would argue again that context would be enough here.
I think my point is that such a breaking change doesn't seem justified if it is not based on convention.
Ok, I've just replaced the streamflow
entry in variables.yml with q
then.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
q
as a proper variable in variables.ymlDoes this PR introduce a breaking change?
No
Other information:
Discussing with @RondeauG , we were deliberating between
qstr
,qstrm
,strf
. I haven't seen any of these variables in many places in litterature, there doesn't seem to be a standard abbreviation apart fromQ
orq
(flow or specific flow ), so I'm enclined to changestrf
if it doesn't feel right.