search

OutpostUniverse / op2ext

Outpost 2 extension module loader
1 stars 0 forks source link

Rename logger #292

Closed Brett208 closed 4 years ago

Brett208 commented 4 years ago

Closes #231

I think this is an improvement overall on readability, although there may be room to tweak some of the names I chose..

Brett208 commented 4 years ago

@DanRStevens would you prefer one of us take another pass on this and then merge or would you prefer just closing the branch unmerged and close issue #231. At this point, I'm okay either way, but it seems you were perhaps not as enthusiastic about the new names.

DanRStevens commented 4 years ago

Wow, I'd really lost context on this one.

I remember there were some naming oddities introduced here, which I kind of wanted to avoid. I don't remember so clearly why we wanted to rename stuff. I wasn't overly attached to some of the old names, so I'm fine with renaming things, though it seems we need to be careful about collisions between global function names and class names.

I could go either way on revisiting versus closing.