Check for LOS during indicator slam - [merged]

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:04

_Merges indicator_loscheck -> staging

After some testing, ecksdee's indicator changes keep the player from doing too extreme redirects, instead they usually just get stuck on large objects. I added a rule that drops the player after 0.5 seconds of losing LOS, which should be similar to how OW1 slam worked. I also changed the speed check from 0 to 2, since the player pretty much never reaches 0 and takes a long time to reach 1. But, the speed check should be unnecessary except in very niche cases, since the LOS check should take care of most slams where the player gets stuck.

[MaxwellJung]

and not eventPlayer.stop_slam) \

negation styling more consistent with Python

[MaxwellJung]

    @Condition not isInLoS(eventPlayer.getEyePosition(), eventPlayer.indicator_slam_position, BarrierLos.PASS_THROUGH_BARRIERS)

negation styling more consistent with Python

[MaxwellJung]

Is this meant to be commented out?

[MaxwellJung]

Looks good other than minor styling changes.

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:17

Commented on src/ow1/heroes/doomfist/slam.opy line 68

changed this line in version 2 of the diff

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:17

Commented on src/ow1/heroes/doomfist/slam.opy line 152

changed this line in version 2 of the diff

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:17

added 1 commit

• fa1e940c - styling changes

Compare with previous version

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:17

Commented on src/ow1/heroes/doomfist/slam.opy line 156

oh, nope. i think i forgot to save before i made the branch/merge request, i had it commented out for testing

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:20

Commented on src/ow1/heroes/doomfist/slam.opy line 156

changed this line in version 3 of the diff

[MaxwellJung]

In GitLab by @hikiru on Nov 9, 2023, 18:20

added 2 commits

• 8dc56909 - Update slam.opy
• 18518f43 - Merge branch 'indicator_los_check' of...

Compare with previous version

[MaxwellJung]

resolved all threads

[MaxwellJung]

Looks good; thanks for contributing!

[MaxwellJung]

approved this merge request

[MaxwellJung]

mentioned in commit 869d89ffd65f206353e41c75e6a1a632fa88c297

[MaxwellJung]

In GitLab by @ghost1 on Nov 10, 2023, 23:13

:tada: This MR is included in version 1.10.1 :tada:

The release is available on GitLab release.

Your semantic-release bot :package: :rocket: