search

OzFramework / oz

Oz is a behavioral web-ui testing framework developed to reduce test maintenance by using a predictive model rather than a scriptive model when writing tests.
Apache License 2.0
23 stars 7 forks source link

CLOSE_BROWSER option no longer works. #64

Closed greenarrowdb closed 6 years ago

greenarrowdb commented 6 years ago

Pretty sure the updates to allow chrome to run headlessly have borked the CLOSE_BROWSER option. The browser now always closes, regardless of how the option is set.

McAllaster commented 6 years ago

I am unable to reproduce this issue on the current Master branch. What are the watir/chromedriver versions that are being used in the broken case?

I'm running

chrome=64.0.3282.140
chromedriver=2.33.506092
watir=6.10.3
McAllaster commented 6 years ago

Confirmed to be an issue on single scenarios.

greenarrowdb commented 6 years ago

Also seems to be an issue when running multiple scenarios, but only the last browser opened gets closed.

greenarrowdb commented 6 years ago

The cause seems to be explained here: https://github.com/watir/watir/issues/523

dbwest commented 5 years ago

Just curious on why this was closed. It is still a problem AFAIK, though I guess it is a problem with watir? In my opinion it becomes Oz's problem as well.... Getting around it with binding.pry now but it is inconvenient.

greenarrowdb commented 5 years ago

I don't want to spend a lot of time trying to fix watir issues. They are already aware of it and will fix it at some point. If it is really a pain then we should escalate with them, not try to monkey patch it here. If we patch it here it will likely not get noticed when Watir eventually does fix it.

dbwest commented 5 years ago

Agreed.