search

P4sca1 / nuxt-headlessui

Headless UI integration for Nuxt. Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.
MIT License
168 stars 7 forks source link

chore: test bundler module resolution #34

Closed danielroe closed 10 months ago

danielroe commented 10 months ago

This is a 'canary' pull request. It aims to ensure that the ecosystem is ready for a shift in the default Nuxt TypeScript module resolution from 'Legacy' to 'Bundler': https://github.com/nuxt/nuxt/pull/24837. You'll need to run your build + type checking tests to verify that things still work; I'm hoping that CI will do that for us so we get an immediate indication of whether there's anything to investigate further here.

'Bundler' module resolution is recommended by Vue and by Vite, but unfortunately there are still many packages that do not have the correct entries in their package.json.

This might include this module or packages that are used by this module. You can see, for example: https://arethetypeswrong.github.io/?p=nuxt-headlessui. The initial red X for node10 needs to be fixed in https://github.com/nuxt/module-builder; you can ignore that for now.

If there are any errors reported in CI for this PR, it would be good to fix them for the sake of any users of this module who enable the Bundler module resolution. Feel free to ping me or others on the Nuxt Discord if you need any help resolving any issues discovered by this PR - and feel free to check out https://github.com/nuxt/nuxt/pull/24837 for any feedback or comments from others affected.

P4sca1 commented 10 months ago

I switched from yarn to pnpm and this MR still included a .yarn/cache entry. Therefore I manually commited the changes in a0a252df77784f5643dee8e8c8760339eeb3f819 and created a new release using the latest nuxt module builder.

danielroe commented 10 months ago

Oops, sorry about that!